bencodezen / vue-enterprise-boilerplate

An ever-evolving, very opinionated architecture and dev environment for new Vue SPA projects using Vue CLI.
7.78k stars 1.32k forks source link

Just a couple of small little things #87

Closed Mike-Loffland closed 5 years ago

Mike-Loffland commented 5 years ago

id="app" is already declared in public index.html... It is then re-declared in main.vue. So, it is declared twice. Anyway, the fact that is was declared twice didn't affect Vue's ability to mount the app as the id="app" in app.vue was being replaced appropriately when built. It just hurts my soul a little bit.

Maybe there is a reason for the the duplicate declaration? If so, I'd like to know your thinking... just so I "get it".

Also, the logo wasn't centered... hurt my soul even more. :)

chrisvfritz commented 5 years ago

Sorry these details hurt your soul. 😄 The id="app in app.vue has a few advantages:

As for the centering, I try not to include anything that won't either be useful for educational purposes, or for most apps. The text-align: center serves no educational purpose and would be immediately deleted for 99% of apps, because it's rarely useful to center all content in a container. For that reason, I don't think it'd be a good fit. 🙂

Mike-Loffland commented 5 years ago

Gotcha. Thanks for the feedback.