search

bencodezen / vue-enterprise-boilerplate

An ever-evolving, very opinionated architecture and dev environment for new Vue SPA projects using Vue CLI.
7.77k stars 1.32k forks source link

fix: fix wrong unit test for nav-bar-routes #99

Closed dobromir-hristov closed 5 years ago

dobromir-hristov commented 5 years ago

This fixes a wrongly written unit test for the nav-bar-routes component.

The test was not assigning the provided prop on each test.

chrisvfritz commented 5 years ago

Thanks for the catch! I just made one small additional improvement to transparently pass all propsData through mountRoutes. 🙂

dobromir-hristov commented 5 years ago

Was not sure whether I should do that or what I did. Decided to be more explicit 😆

Do you think a comment saying that this element is combining Render functions with JSX is appropriate?

chrisvfritz commented 5 years ago

Good question. 🙂 I'm leaning towards not having a comment, simply because there quite a few places in the codebase where I use a render function with JSX and I'd rather not add comments to all of them. 😄