search

bencompton / jest-cucumber

Execute Gherkin scenarios in Jest
Apache License 2.0
657 stars 115 forks source link

Proposal to Replace Deprecated TSLint with ESLint, Prettier #193

Closed pplancq closed 6 months ago

pplancq commented 6 months ago

Hello,

I am proposing a significant change to our codebase. As TSLint is now deprecated, I suggest we replace it with ESLint and Prettier. I have used my personal configurations which are quite strict. However, I am open to discussion if there are any concerns or suggestions.

In addition, I have added Husky to our project. Husky will automatically run eslint --fix on every new file during the pre-commit hook. This will ensure that our code remains clean and adheres to our coding standards.

Please review these changes and provide your feedback.

Best.

bencompton commented 6 months ago

Thanks for contributing this! Getting the tooling up to date would be wonderful, and I should have some time to review this evening.

bencompton commented 6 months ago

I'm good with the tools you've introduced here and am also up for trying out your OSS dev-tools project. If you wouldn't mind getting the conflicts resolved (from merging your other PR), we can get this one merged as well. Thanks again!

pplancq commented 6 months ago

Hello,

I'm rebasing my branch to correct the conflicts. I'm glad to see you appreciate these changes. Yes you could use my dev-tools project for your react projects that's why I made it public.