search

bencompton / jest-cucumber

Execute Gherkin scenarios in Jest
Apache License 2.0
657 stars 115 forks source link

Fix no build before npm publish #199

Closed pplancq closed 6 months ago

pplancq commented 6 months ago

Hello @bencompton ,

Sorry for the direct mention, but there's a big problem with the github publish action. The build step is missing, which means the dist folder isn't published to the npm registry.\ This makes the library unusable.

image

I suggest this quick fix to quickly fix and republish a patched version.

bencompton commented 6 months ago

Thanks a bunch for catching this! I tested 4.0.1 in another project, but now that I double check, it was still using the previous version. :facepalm:

pplancq commented 6 months ago

No problem, to err is human as they say. On the other hand, I notice that you didn't release 4.0.2 on the master. image