janscience
commented
8 years ago Hi Juan,
thank you for starting to implement this!
I put some technical comments into the code...
Once you implemented this we will merge it.
I like the wavefish with the n harmonics. I might make this more general by supplying relative amplitudes andnphases for each harmonics. Similar for the pulse fish we might supply amplitudes, relative position and width (standard deviation) for n gaussian pulses.
And then I will add Apteronotus and Eigenmannia. Likewise we should add some standard mono- and biphasic pulse fish.
Jan
On 06/30/2016 11:25 AM, Juan F. Sehuanes wrote:
I created a Fakefish module. So far it only has a pulse-fish and a wave-fish. We might want to add more things to it (s.a. different species like Eigenmania), but this should be fine for what we need it now i.e. the TESTS!
please review and add suggestions!
You can view, comment on, or merge this pull request online at:https://github.com/bendalab/thunderfish/pull/34
Commit Summary
- fakefish.py created. Pulse-fish data now available with customizable parameters. Still need to work on wave-fish.
- almost done. Need to finish plot for pulsefish.
fakefish.py ready for external review.
File ChangesA thunderfish/fakefish.py https://github.com/bendalab/thunderfish/pull/34/files#diff-0 (173)
Patch Links:- https://github.com/bendalab/thunderfish/pull/34.patch
- https://github.com/bendalab/thunderfish/pull/34.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bendalab/thunderfish/pull/34, or mute the thread https://github.com/notifications/unsubscribe/ALfehO3pOmF3_Ik3duGE32cMyQrUW5e3ks5qQ4twgaJpZM4JB9zW.
Prof. Dr. Jan Benda Abteilung Neuroethologie Institut fuer Neurobiologie Universitaet Tuebingen Auf der Morgenstelle 28 E phone: +49 / 7071 - 29 74573 72076 Tuebingen fax: +49 / 7071 - 29 5144
coveralls
I created a Fakefish module. So far it only has a pulse-fish and a wave-fish. We might want to add more things to it (s.a. different species like Eigenmania), but this should be fine for what we need it now i.e. the TESTS!
please review and add suggestions!