Fix get volume on WebOS 5.0

bendavid / aiopylgtv

Library to control webOS based LG Tv devices

MIT License

143 stars 47 forks source link

Fix get volume on WebOS 5.0 #27

Closed marciogranzotto closed 3 years ago

marciogranzotto commented 3 years ago

Fixes #26

Acrobot commented 3 years ago

Thank you for the change, but it seems like it duplicates my PR #25 and does not fix the get_volume() function (I am not the repo owner).

EDIT: Actually, it seems like you are handling it better than me, since I had no idea that the volume worked on an older version of webOS with just the "volume" dictionary key. I suggest then you just add the same method for getting the volume in line 881 (res.get("volumeStatus", res).get("volume"))

marciogranzotto commented 3 years ago

@Acrobot thanks! I've updated the get_volume function as well.

@bendavid can you take a look at this? This is breaking the Home Assistant integration, so it would be great if we could merge it ASAP