bendavid / aiopylgtv

Library to control webOS based LG Tv devices
MIT License
143 stars 47 forks source link

Add client_key argument #28

Closed cyr-ius closed 3 years ago

cyr-ius commented 3 years ago

Like asking I just pushed the PR. If we can get a new version in pypi, I'm up for it. Because I want to deliver a new version of LG Webos TV component for Home Assistant. and suddenly I could directly include the new version.

bendavid commented 3 years ago

Are you planning to use this feature to bypass the use of the config file in Home Assistant?

cyr-ius commented 3 years ago

Are you planning to use this feature to bypass the use of the config file in Home Assistant?

Yes quite. I created an integration via the HA configuration flow and the goal is to do without the file, however I need a new version in pypi to use it from HomeAssistant Currently the version used is aiopylgtv (0.3.3)

https://github.com/Cyr-ius/home-assistant/tree/configflow_webostv

bendavid commented 3 years ago

0.4.0 is on pypi now which should also skip the config file entirely if a key is provided at initialization

cyr-ius commented 3 years ago

0.4.0 is on pypi now which should also skip the config file entirely if a key is provided at initialization

I have just included the new version in the evolutions of Home Assistant that I am preparing. I hadn't seen it, but no matter what, you still generate the file (line 201). I generate it in / tmp because it is no longer useful. We should have found a solution to avoid creating it.