search

bendavid / aiopylgtv

Library to control webOS based LG Tv devices
MIT License
143 stars 47 forks source link

Fixed parsing model names for OLED TVs later than 2019 #55

Open develancer opened 2 years ago

develancer commented 2 years ago

This is a very simple fix, but necessary to be able to use 1D/3D LUT calibration on 2020–2021 OLED TVs. Should work for the next few years, as well.

develancer commented 2 years ago

@bendavid Not sure why the checks keep failing. It looks like a GitHub/Azure issue, unrelated to the actual changes.

develancer commented 2 years ago

@chros73 Any idea why these checks keep failing?

chros73 commented 2 years ago

Not sure why the pre-commit script failed, try to amend the commit and push it up again, maybe it was a glitch in Azure.

But more importantly: have you tried out the calibration functionality with newer models? Which model do you have? There were reports that it doesn't work on C1, and allowing this blindly can even break TVs ...

develancer commented 2 years ago

@chros73 The checks failed again.

As for the other question: yes, I did use the script with my 48-inch C1. DDC reset and 1-D LUT upload went smoothly. Haven’t tried all functions, though.

chros73 commented 2 years ago

The checks failed again

Hm, with the same error, I'm clueless. Do you have the hooks enabled locally? If so, did it pass locally?

yes, I did use the script with my 48-inch C1. DDC reset and 1-D LUT upload went smoothly. Haven’t tried all functions, though.

Thanks, good to know! Not sure what was the issue with other users then. I think something is changed in C1, there should be a complementary 1dlut as well, that can affect DDC reset. Also DoVi config could be changed (in CX/C1/C2) and that is the scary one :)

develancer commented 2 years ago

Hm, with the same error, I'm clueless. Do you have the hooks enabled locally? If so, did it pass locally?

Yes, they most certainly did. It looks like a github vs azure configuration issue. Only the administrator of this repo may be able to fix it.

chros73 commented 2 years ago

OK, thanks for the code otherwise! @bendavid can still manually add this or fix the azure issue if he thinks it's safe to go. Nevertheless, I'll probably get a 2022 model soon(ish), so I can also try out the calibration functionalities. So let's keep in contact :)

chros73 commented 1 year ago

Thanks for the idea, I extended it in the new bscpylgtv v0.4.0, it's mostly about calibration changes, lot of new stuff has been added. Enjoy!

chros73 commented 1 year ago

Actually I just scrapped the whole logic based on model names, and I implemented another one based on chip types (and added more enhancements).