search

bendavis78 / paper-date-picker

Material design date picker component for polymer
http://bendavis78.github.io/paper-date-picker/
MIT License
225 stars 132 forks source link

paper-date-picker hides iron-icons #188

Closed amanshu-kataria closed 7 years ago

amanshu-kataria commented 7 years ago

I used iron-icons in my app written in Polymer 2, but when I imported paper-date-picker the iron-icons disappeared. By inspecting I came to know that the icons are still at their respective positions but are hidden. I guess this has something to do with the paper-date-picker's compatibility issues with Polymer 2.

amanshu-kataria commented 7 years ago

@bendavis78 need help please.

admwx7 commented 7 years ago

Sorry @amanshu-kataria but we are still in the process of porting this element over to 2.0, hope to be wrapping that up shortly, if it's still an issue after that point, feel free to open a new issue. Keep an eye on #192 in the meantime.

amanshu-kataria commented 7 years ago

Are you trying to make it hybrid or just compatible with 2.0?

From: Austin Murdock notifications@github.com Sent: Tuesday, September 19, 2017 3:44:31 AM To: bendavis78/paper-date-picker Cc: Amanshu Kataria; Mention Subject: Re: [bendavis78/paper-date-picker] paper-date-picker hides iron-icons (#188)

Closed #188https://github.com/bendavis78/paper-date-picker/issues/188.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/bendavis78/paper-date-picker/issues/188#event-1254383730, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMaUTf1_aoQosf9cilNwXl7of2Slw6SWks5sjutHgaJpZM4OEYeN.

admwx7 commented 7 years ago

I was planning on going hybrid originally however I think I'm just going to jump it straight to 2. If you want to run hybrid on your element you can resolve to ^1.0 || ^2.0 against this element.

amanshu-kataria commented 7 years ago

I was trying to make it compatible with 2.0 but faced some issues as I mentioned earlier. Should I send a PR? It would also save your time as well. :)

From: Austin Murdock notifications@github.com Sent: Tuesday, September 19, 2017 10:58:20 AM To: bendavis78/paper-date-picker Cc: Amanshu Kataria; Mention Subject: Re: [bendavis78/paper-date-picker] paper-date-picker hides iron-icons (#188)

I was planning on going hybrid originally however I think I'm just going to jump it straight to 2. If you want to run hybrid on your element you can resolve to ^1.0 || ^2.0 against this element.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/bendavis78/paper-date-picker/issues/188#issuecomment-330433433, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMaUTX4IfpzjnI4kFGIVHYSN5e4gEHzaks5sj1D0gaJpZM4OEYeN.

admwx7 commented 7 years ago

There's a PR out already that's working and just needs some fixes. Hope to get it merged in the next day or two and a pre-release out.

amanshu-kataria commented 7 years ago

Cool. Looking forward towards 2.0 (:

From: Austin Murdock notifications@github.com Sent: Tuesday, September 19, 2017 11:04:25 AM To: bendavis78/paper-date-picker Cc: Amanshu Kataria; Mention Subject: Re: [bendavis78/paper-date-picker] paper-date-picker hides iron-icons (#188)

There's a PR out already that's working and just needs some fixes. Hope to get it merged in the next day or two and a pre-release out.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/bendavis78/paper-date-picker/issues/188#issuecomment-330434202, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMaUTS6LGmN1LWESfNMnWDsy_4xpwXQ3ks5sj1JggaJpZM4OEYeN.