search

bendavis78 / paper-date-picker

Material design date picker component for polymer
http://bendavis78.github.io/paper-date-picker/
MIT License
226 stars 132 forks source link

Upgrade to Polymer 2.0 #192

Closed loopingz closed 6 years ago

loopingz commented 6 years ago

I did the update to Polymer 2.0 it seems to work on my side.

The test is broken because the $$ does not exist anymore and I haven't found a way to migrate it to Polymer 2.0 yet

fl4p commented 6 years ago

Thank you!

You still need to fix dependencies. Dependency to bendavis78/moment-element, which depends on Polymer 1.0 breaks it.

You should also remove the 2 resolutions from bower.json (they are unnecessary) and upgrade the devDependecy webcomponentsjs to #^1.0.0.

loopingz commented 6 years ago

So i checked and that's why the resolution was necessary, the moment-element is not depending on any version of polymer in fact.

I did the update on the webcomponentsjs

loopingz commented 6 years ago

I did realign the branch for the PR and did all the fixs required i think I even did move the listeners to connect/disconnect callback

admwx7 commented 6 years ago

For the shadowRoot question, during the transition to polymer 2 it went from having to query on this to this.root to this.shadowRoot, wasn't sure which was stable in 2.x, looked into it and this.shadowRoot is consistent if you're running 2.x, but not if you're running hybrid, so we are good.

loopingz commented 6 years ago

Thank you !