search

bendavis78 / paper-date-picker

Material design date picker component for polymer
http://bendavis78.github.io/paper-date-picker/
MIT License
225 stars 132 forks source link

Don't change the time on the bound date #205

Closed rwestlund closed 6 years ago

rwestlund commented 6 years ago

This fixes a regression for an issue originally fixed in #50.

rwestlund commented 6 years ago

FWIW, I've been using this branch in production. Seems good enough to cut a v2.0 now.

admwx7 commented 6 years ago

This functionality actually works the same way as the old system. When the date is changed hours get set to 0. Prior to 1.1.5 though it would make that update when the date object changed, which meant if you bound it to another element and the other element updated the time this element would clear it out because the date changed logic.

This is a breaking change for user's that rely on a date independent of a time-picker, I'm fine with the change to remove it from selection clearing out hours, but add it in when the date is created so those users don't have to clear our hours manually and I'll merge. I'll also post in the release the breaking change to only clear hours on date creation instead of selection.

rwestlund commented 6 years ago

Done. Sorry for the delay.