bendavis78 / paper-time-picker

Material design time picker component for polymer
http://bendavis78.github.io/paper-time-picker/
MIT License
89 stars 63 forks source link

Declaration of _formatTime in paper-time-picker.html #18

Closed opus1269 closed 8 years ago

opus1269 commented 8 years ago

On line 170 the function is declared as:

_formatTime(hour, minute) {
          var period = (hour % 24) < 12 ? 'AM' : 'PM';
          hour = hour % 12 || 12;
          minute = ('0' + minute).substr(-2);
          return hour + ':' + minute + ' ' + period;
        },

It passes my linter but it crashes uglify at the opening ( . I think it should be:

_formatTime: function(hour, minute) {
          var period = (hour % 24) < 12 ? 'AM' : 'PM';
          hour = hour % 12 || 12;
          minute = ('0' + minute).substr(-2);
          return hour + ':' + minute + ' ' + period;
        },
bendavis78 commented 8 years ago

Fixed in master.