bendavis78 / paper-time-picker

Material design time picker component for polymer
http://bendavis78.github.io/paper-time-picker/
MIT License
89 stars 63 forks source link

Remove implicit dialog style inclusion #21

Open bendavis78 opened 8 years ago

bendavis78 commented 8 years ago

The dialog style is currently included in the main html file for backward compatibility. This should be removed in the next version.

zmoshansky commented 8 years ago

@bendavis78 When this happens, what will be the proper way of including the style? I currently need to have <style is="custom-style" include="paper-time-picker-dialog-style"></style> in the element where the dialog is hosted (tested on paper-time-picker 1.1 & master).

I've also added a match shim to pull the header all the way to the bottom in landscape.

<template>
    <style>
      :host { display: block; }
      @media (max-width: 560px) {
        .match {
          height: 0;
          width: 0;
        }
      }
      @media (min-width: 561px) {
        .match {
        width: 168px;
        height: 56px;
        position: absolute;
        left: 0px;
        bottom: 0px;
        background: var(--default-primary-color);
        }
      }
    </style>

    <style is="custom-style" include="paper-time-picker-dialog-style"></style>
    <paper-dialog id="dialog" modal class="paper-time-picker-dialog">
      <paper-time-picker id="timePicker"></paper-time-picker>
      <div class="buttons">
        <span class="match"></span>
        <paper-button dialog-dismiss>Cancel</paper-button>
        <paper-button dialog-confirm on-tap="close">OK</paper-button>
      </div>
    </paper-dialog>
  </template>
admwx7 commented 6 years ago

Going to move this to the 2.0 milestone since it's a breaking change. Part of that will be converting to Polymer 2.0 as well.