search

bendavis78 / paper-time-picker

Material design time picker component for polymer
http://bendavis78.github.io/paper-time-picker/
MIT License
89 stars 63 forks source link

Polymer 2.0 Support #53

Closed rwestlund closed 5 years ago

rwestlund commented 7 years ago

Any plans to make this a hybrid element compatible with Polymer 2.0?

ThilinaTCH commented 7 years ago

@bendavis78 Is this in road map? If so any estimated date please..

Saneyan commented 7 years ago

Sent a pull request to support Polymer 2.0.

ArthurJahn commented 7 years ago

In fact, there are still changes to be mande in paper-time-picker and paper-clock-selector. I'm having errors with property-accessors related to query-selector and/or dom-if

captura de tela 2017-06-09 as 13 43 44

Did you get any problem like this? In general the component works well, but you have to tap the hour/minute before selecting its value, might be related to this query-selector error.

amanshu-kataria commented 7 years ago

@bendavis78 Can we expect it to support Polymer 2 any soon?

admwx7 commented 7 years ago

@amanshu-kataria I'll be putting out a PR to support hybrid when I get some free time, sorry for being so inactive on here, promised I'd do some stuff to help out a while back and got slammed with work!

amanshu-kataria commented 7 years ago

@admwx7 thanks. BTW I tried migrating the code to Polymer 2, but facing some issues. If you have some time then please check it. Here's the link to branch. And here's the issue.

admwx7 commented 7 years ago

I saw that. I've been migrating a lot of elements to hybrid at work and creating a few new ones as well so I've got the pattern down pretty solid, just need some free time to write some tests before I start the conversion to ensure I don't break anything

amanshu-kataria commented 7 years ago

@admwx7 please let me know what all I can do to help you. I would love to. :)

admwx7 commented 7 years ago

I'm hoping to push the testing scaffold with a few basic tests and version bump this weekend, after that if you want to add some additional tests, that would be great!

On Fri, Sep 15, 2017, 11:29 AM Amanshu Kataria notifications@github.com wrote:

@admwx7 https://github.com/admwx7 please let me know what all I can do to help you. I would love to. :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bendavis78/paper-time-picker/issues/53#issuecomment-329832275, or mute the thread https://github.com/notifications/unsubscribe-auth/ABpRr8QDK25HF-2hk-pGDxVsEYyLGNn2ks5siqXVgaJpZM4NKpcr .

admwx7 commented 6 years ago

^1.2.0 should pick up the release candidate tag I just added against these changes, anyone feel daring enough to give it a try? We'll be integrating things on our side in the near future and releasing an official 1.2.0 once we've gone through that but additional testing in other apps would be nice.

rwestlund commented 6 years ago

I've been using 1.2.0-rc2 in production for several months now with no problems. Let's make it official and move on to Polymer 3 support.

admwx7 commented 5 years ago

No one has complained, closing this out.