search

bendavis78 / paper-time-picker

Material design time picker component for polymer
http://bendavis78.github.io/paper-time-picker/
MIT License
89 stars 63 forks source link

Clock binding work #61

Closed Harit-m closed 6 years ago

Harit-m commented 6 years ago

zeropadding,binding work added

Harit-m commented 6 years ago

Please do not consider this PR. I intended to send this to a different repository. Sorry for the confusion

On Tue, Dec 19, 2017 at 10:50 PM, Austin Murdock notifications@github.com wrote:

@admwx7 requested changes on this pull request.

Sorry for not clarifying the comments thing, while inline comments are appreciated for clarity on sections that are particularly confusing, what I meant here is the functions themselves need documented using jsdocs: http://usejsdoc.org/

It's the documentation standard that Polymer relies on for generating documentation for the elements on their public pages (webcomponents.org docs are generated from these)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bendavis78/paper-time-picker/pull/61#pullrequestreview-84525661, or mute the thread https://github.com/notifications/unsubscribe-auth/AgGLD4QG2pV5hwh3K9fnSHPhDf54X7-Dks5tB_BBgaJpZM4Qu2jt .

admwx7 commented 6 years ago

PR sent to wrong repo, closing.