search

bendavis78 / paper-time-picker

Material design time picker component for polymer
http://bendavis78.github.io/paper-time-picker/
MIT License
89 stars 61 forks source link

Rendering Issue when not in dialog #8

Closed zmoshansky closed 8 years ago

zmoshansky commented 9 years ago

Used on polymer 1.0+; It renders fine when in a dialog. Works great:

    <paper-dialog id="dialog" modal class="paper-time-picker-dialog">
      <paper-time-picker id="timePicker"></paper-time-picker>
      <div class="buttons">
        <paper-button dialog-dismiss>Cancel</paper-button>
        <paper-button dialog-confirm>OK</paper-button>
      </div>
    </paper-dialog>

Renders all the clock numbers on top of each other:

        <paper-time-picker id="timePicker"></paper-time-picker>

screenshot from 2015-08-24 11-30-03

bendavis78 commented 9 years ago

I'm unable to reproduce this, but I've been making a bunch of bugfixes lately. Can you check again using master?

ghost commented 8 years ago

I think paper-input interacts with paper-time-picker, because:

This works to me:

<paper-button on-tap='showDialog'>dsfs </paper-button>                        
<paper-dialog on-iron-overlay-closed="closing" id="dialog" modal class="paper-time-picker-dialog">
  <paper-time-picker id="timePicker" force-narrow></paper-time-picker>        
  <div class="buttons">                                                       
    <paper-button dialog-dismiss>Cancel</paper-button>                        
    <paper-button dialog-confirm>OK</paper-button>                            
  </div>                                                                      
</paper-dialog>

and this not

<paper-input on-tap='showDialog' label="Input label"></paper-input>           
<paper-dialog on-iron-overlay-closed="closing" id="dialog" modal class="paper-time-picker-dialog">
  <paper-time-picker id="timePicker" force-narrow></paper-time-picker>        
  <div class="buttons">                                                       
    <paper-button dialog-dismiss>Cancel</paper-button>                        
    <paper-button dialog-confirm>OK</paper-button>                            
  </div>                                                                      
</paper-dialog>

The only difference is triggering node.

radiia commented 8 years ago

Same problem for me, even with paper-button and using it inside a paper-dialog element:

screen shot 2015-11-04 at 17 06 36
ghost commented 8 years ago

This https://github.com/bendavis78/paper-time-picker/commit/d8ec0fb08245b43b94978f1ce6cc5bacfc09f6c4 from https://github.com/bendavis78/paper-time-picker/issues/16 solved my issue.

radiia commented 8 years ago

Thank you @xliiv , it works perfectly. Saved my day!

masonlouchart commented 8 years ago

What do you think about make soon a new release and close this issue ?

bendavis78 commented 8 years ago

This should be fixed in master.