Double quote missing on some HTML property values

bendc / frontend-guidelines

Some HTML, CSS and JS best practices.

8.29k stars 653 forks source link

Closed AllThingsSmitty closed 6 years ago

AllThingsSmitty commented 9 years ago

Ben, first, AWESOME repo.

Second, I noticed that some of the syntax under the HTML section doesn't contain quotes for all property values. Ex:

<input type=email placeholder=you@email.com required>

In some cases you do include it:

<input type="email" placeholder="you@email.com" required>

For consistency I think you want to keep with one pattern.

hstarorg commented 8 years ago

I agree.Also I think missing double quote affect readability.

e-cloud commented 8 years ago

Obviously, the author has left github for a while~~~

bendc commented 6 years ago

Fixed -- sorry for the "small" delay 🤭

AllThingsSmitty commented 6 years ago

👍🏼Thanks.

xypnox commented 1 year ago

The current repo code disregards quotes around attributes. The w3c recommends quotes around values.