search

benderjs / benderjs

The anti-human approach to JavaScript testing
Other
29 stars 5 forks source link

Updated dependencies #255

Closed dmytro-krekota closed 7 years ago

dmytro-krekota commented 7 years ago

When I tried to run tests with benderjs, I received an error: Potentially unhandled rejection [1] TypeError: Cannot read property 'prototype' of undefined bender To fix this problem I put the latest version of socket.io to /node_modules/benderjs/node_modules/ instead of old socket.io. So, I offer to update dependencies in your project.

mlewand commented 7 years ago

Thanks @DmitryKrekota. Sorry for taking it so long for us to review this change, but we had very little time to check for Bender (as seen above).

Let's get it reviewed.

msamsel commented 7 years ago

Hi @DmitryKrekota, thank you for your pull request. Unfortunately your pull request update too much packages, what cause other errors e.g. broadway. Based on this case I was able to prepare another solution with smaller update, which is working. :) You can find my pull here: #256. It should work with newer nodejs version and fix mentioned error. We're going to introduce changes to master branch in near future. You'll be update when this happen.

dmytro-krekota commented 7 years ago

@msamsel, ok, I do not mind and I will wait for marging #256 PR.

mlewand commented 7 years ago

Mentioned #256 fixes support for node 7.x without breaking broadway. Thanks for the contribution!