Remove name mappings for windows

vweevers commented 9 years ago

The winDetectMap should be updated, or removed all together. The "ff" to "firefox" mapping is old, as is "phantom" to "phantomjs". Chromium is not supported by win-detect-browsers (and chromium has no Windows installer as far as I know, so it's not detectable) so it can be left out. The only one that needs mapping is "chrome" to "google-chrome".

winDetectMap = {
  chrome: 'google-chrome',
  chromium: 'chromium-browser',
  ff: 'firefox',
  phantom: 'phantomjs',
  safari: 'safari',
  ie: 'ie',
  opera: 'opera'
};

gregpabian commented 9 years ago

Cool, again, a PR is welcome :)

alessioalex commented 9 years ago

I'll take care of that will my pull request for https://github.com/benderjs/browser-launcher2/issues/24

vweevers commented 9 years ago

@alessioalex great, thanks :+1:

gregpabian commented 9 years ago

Resolved with bdb2ba05993685b6742944f2fb4b5461b3f33047 and 217f2122f97b8294d970b9abc753ed4273db160b

benderjs / browser-launcher2

Remove name mappings for windows #26