benderjs / browser-launcher2

☠ This package is no longer maintained ☠
Other
24 stars 13 forks source link

Can't manually stop PhantomJS instance on Windows #32

Open gregpabian opened 9 years ago

gregpabian commented 9 years ago

That's because PhantomJS's executable is not being started directly by the browser-launcher but using a CMD script from NPM directory (phantomjs.CMD). So the instance actually points to the script, not the executable.

vweevers commented 9 years ago

I mentioned it earlier, but this will be fixed by win-detect-browsers, returning the executable instead of the .cmd. Haven't got around to finishing that issue.

gregpabian commented 9 years ago

Alright, I'll leave this one for now hoping you'll manage to solve that issue on your side. Thanks.

vweevers commented 9 years ago

Released 2.0, should now return phantomjs.exe.