search

bendmorris / spinehaxe

Spine runtime for Haxe 3. Based on current AS3/libgdx runtimes.
Other
64 stars 28 forks source link

Core code depends on openfl.Vector #12

Closed joshminor closed 9 years ago

joshminor commented 9 years ago

I'm trying to use this code for Flambe, but the use of openfl.Vector in the core components is making this difficult. Is there any way to switch to a more generic method?

bendmorris commented 9 years ago

I was actually using haxe.ds.Vector for fixed length and Array for variable length until yesterday, a pull request changed them all to openfl.Vector. We should probably undo that change since the runtime isn't otherwise dependent on openfl.

@Beeblerox, would it cause any issues for Flixel to revert to haxe.ds.Vector?

Beeblerox commented 9 years ago

@bendmorris don't know. i need to try it. Or we can add typedef which will map to openfl.Vector if we use openfl or to haxe.ds.Vector in other case

Beeblerox commented 9 years ago

give me little time to make pull request for it

Beeblerox commented 9 years ago

here is pull request for this issue: https://github.com/bendmorris/spinehaxe/pull/13

Beeblerox commented 9 years ago

@bendmorris can you check my pull request. i think it should be not so openfl-dependent now

Beeblerox commented 9 years ago

@bendmorris or you can wait some time, and i'll add mesh coloring in this pull request (probably tomorrow). P.S. sorry for spamming

Beeblerox commented 9 years ago

ok, implemented tinting and blending on native targets. now you can safely merge my pull request

bendmorris commented 9 years ago

Thanks @Beeblerox - the dependency on openfl is now gone.