search

bendrucker / angular-credit-cards

Angular directives for parsing and validating credit card inputs
MIT License
328 stars 98 forks source link

Broken link in ReadMe? #58

Closed NumEricR closed 9 years ago

NumEricR commented 9 years ago

Hi,

I've noticed a broken link in README: see "Exposes the card type as $ccType on the model controller". I think this link should use https://github.com/bendrucker/creditcards-types#card-types

bendrucker commented 9 years ago

Good catch, please submit a PR

NumEricR commented 9 years ago

I think you could do it faster than me! :wink: You know I have to fork this project, commit, make the PR, ... and this is only to fix a link :confused:

bendrucker commented 9 years ago

Nope, you can make it happen faster. You can submit PRs via GitHub very easily.

antoinepairet commented 9 years ago

@NumEricR Just browse the source, click on the pencil in top right corner, perform the edit and submit the PR. Github will guide your through every step ;-)