search

bendrucker / creditcards-types

Card type definitions and methods for creditcards
MIT License
70 stars 20 forks source link

Add credit card type: Elo and Hipercard #32

Closed vendramini closed 7 years ago

vendramini commented 7 years ago

Hi, could u add the Elo and Hipercard type? They are very common in Brazil. Thanks!

https://pastebin.com/duVq0tUv

bendrucker commented 7 years ago

See past issues, happy to review a PR but I don't take issues for uncommon card types.

vendramini commented 7 years ago

Yep, u r correctly, I apologize for this issue.

bendrucker commented 7 years ago

That's ok, no one's done it so far because no one's tracked down official docs. To date I've been able to make all the regular expressions non-overlapping. These cards with very broad/undocumented ranges might require some internal changes.

vendramini commented 7 years ago

Searching on brazilian forums I found that these companies doesn't answer with official docs, that's the reason some people did a compilation on pastebin sharing the currently mostly-accepted solution. Sad.

Thanks for your attention.