search

bendudson / BOUT

NOTE: BOUT++ now at https://github.com/boutproject/BOUT-dev
GNU Lesser General Public License v3.0
24 stars 34 forks source link

Namespace clash #21

Open seanfarley opened 14 years ago

seanfarley commented 14 years ago

Due to using common names, such as 'Mesh' and 'Solver,' we are running into compiler / linking issues when linking with other libraries. Open to suggestions but this came up with the use of 'real' which we hacked to 'BoutReal' but we need to fix this kind of problem once and for all. Should we use namespaces? Unique names (i.e. BoutMesh, BoutSolver, etc.)?

bendudson commented 14 years ago

Propose changing "BoutReal" to just "double" as it's hard-wired in several places to be double anyway. Hard to think of any reason for using floats

For namespace, a single "bout" namespace might be best

seanfarley commented 14 years ago

I agree with both points. I'll implement this soon.