Closed bendudson closed 1 month ago
There are a couple of extra gotchas with the new BOUT++ version:
If we merge this PR as it is, mxorder
will no longer work: https://github.com/boutproject/BOUT-dev/issues/2946
EDIT: Resolved in https://github.com/boutproject/BOUT-dev/pull/2949
And BOUT++ may not compile: https://github.com/boutproject/BOUT-dev/issues/2944
I made a PR for the BOUT++ version on my fork so that it's easier to see what's in hermes3-temp
:
https://github.com/mikekryjak/BOUT-dev/pull/2
BOUT++ compilation issue now resolved in this PR, I think this is the last gotcha (once merged) https://github.com/boutproject/BOUT-dev/pull/2967
Using a branch
hermes3-temp
rather thannext
, to keep some patches for additional limiters.