search

benduran / lets-version

A package that reads your conventional commits and git history and recommends (or applies) a SemVer version bump for you
MIT License
1 stars 3 forks source link

--force not working #26

Open amybingzhao opened 1 month ago

amybingzhao commented 1 month ago

Hi Ben!

It seems like there's a bug in using npx lets-version get-bumps --force. When running it on a repo that has no new changes, I'm consistently getting:

No bumps can be applied. This likely means you have not yet created your first version with the lets-version library, or no changes have occurred since the last version bump.

It seems like there might be a bug here: https://github.com/benduran/lets-version/blob/main/src/lets-version.ts#L375-L404 -- the result of updating bumpTypebyPackageName never seems to be used.

I found that I had to downgrade to version 0.8.3 to get --forceAll to work as expected, which means I also had to downgrade turbo-tools to 0.5.5 :'(

benduran commented 1 month ago

Hi @amybingzhao thanks for the report! My apologies for not seeing this sooner.

I'm in the process of moving, so I may not be able to get to this until later in the week. Happy to review any PRs you may have, though.

Thanks for your patience!

benduran commented 1 month ago

@amybingzhao would it be possible for you to setup a repro dummy repository? 🤞

benduran commented 1 month ago

@amybingzhao there was a bug in some of the logic that determined which packages should receive bumps. It's possible this might be addressed with the latest release, 1.1.4. Please give that a shot and let me know if that addresses this issue for you