search

bendyworks / payroll

Track & analyze payroll in order to make informed decisions.
13 stars 11 forks source link

Replace best_in_place with a different in place editing solution #53

Open aterrype opened 4 years ago

aterrype commented 4 years ago

The best_in_place gem is no longer being maintained, and should be replaced with an alternative that is. The main version of the gem has an unfixed deprecation warning, which we have currently patched with a local fork of it, but we'd like something more stable and maintainable long-term.

falonofthetower commented 3 years ago

It looks like there is actually movement here with an update for Rails 6 compatibility in the last 12 days. On the other hand I suspect StimulusJS is the more appropriate solution here?

aterrype commented 3 years ago

The Rails 6 stuff was one of our main issues with it, so that's good. But yeah, there might be better solutions here regardless. We didn't look too deeply into the alternatives at the time.

rogerroelofs commented 3 years ago

Given that we've moved to React for charts, we could pretty easily do it in React also. Best_in_place still seems like the only reasonable gem based approach but isn't doing so much that we need to feel tied to it. If we decide we want to ditch best_in_place I'd be happy to take this.

aterrype commented 3 years ago

I was starting to look into this one, and now that we have webpacker set up, I think it makes sense to switch over to StimulusJS - it seems designed for this use case and is a lot better maintained.