Strengthen the project - Githubissues

benedekfazekas / mranderson

Dependency inlining and shadowing

Eclipse Public License 1.0

151 stars 14 forks source link

Strengthen the project #60

Closed vemv closed 3 years ago

vemv commented 3 years ago

Commits:

Simplify threading setup
- Creates fewer threads, bounding them by the CPU count.
- An analysis is offered in https://github.com/benedekfazekas/mranderson/issues/57#issuecomment-937536702
Introduce a CI matrix
Add an e2e test against cider-nrepl
Add an e2e test against refactor-nrepl

Build is green in my Circle account.

I was happy to find that finally, atm there isn't a reproducible bug when building cider-nrepl through the matrix 👍 still, having it in the suite seems greatly desirable for moving in a future with greater confidence.

benedekfazekas commented 3 years ago

thanks! let me have a play with it

benedekfazekas commented 3 years ago

any chance i can see the circleci builds somewhere?

vemv commented 3 years ago

Not sure if this will show up for you https://app.circleci.com/pipelines/github/reducecombine/mranderson?branch=strengthen-project

Else here's a screenshot:

benedekfazekas commented 3 years ago

can't see an extreme slowness with the integration tests on circleci which bothers me because it is still very slow with jdk16 and 17 on my local compared to jdk11. that is not a showstopper for this PR apparently (not any worse than without the PR) but just curious: can you repro the slowness on your local?

benedekfazekas commented 3 years ago

really nice work, ta @vemv

vemv commented 3 years ago

🍻!

can you repro the slowness on your local?

Now that you asked, yes I could!

(normally I don't perceive it b/c JDK8 is my default one)

I failed to attach yourkit, I think that doing so to a plugin is tricky 😞

Anyway it's kind of good news that the slowness can't be repro'd in CI. That's one nice incentive to release artifacts from CI as we all ideally would.