benedekfazekas / mranderson

Dependency inlining and shadowing
Eclipse Public License 1.0
151 stars 14 forks source link

Introduce `pmap-runner` as a temporary measure #63

Closed vemv closed 2 years ago

vemv commented 2 years ago

Can help avoid possibly experiencing https://github.com/benedekfazekas/mranderson/issues/56

It can be set via export LEIN_JVM_OPTS="-Dmranderson.internal.no-parallelism=true" and I verified that it's effectively set via a temporary println.

Cheers - V

codecov-commenter commented 2 years ago

Codecov Report

Merging #63 (37c2a4b) into master (3a9992c) will increase coverage by 0.06%. The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   64.25%   64.31%   +0.06%     
==========================================
  Files           7        7              
  Lines         705      709       +4     
  Branches       50       50              
==========================================
+ Hits          453      456       +3     
- Misses        202      203       +1     
  Partials       50       50              
Impacted Files Coverage Δ
src/mranderson/move.clj 91.41% <87.50%> (-0.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a9992c...37c2a4b. Read the comment docs.

vemv commented 2 years ago

@benedekfazekas happy new year 🍻

any luck with this one?

vemv commented 2 years ago

As a brief commentary, I'm using this in https://github.com/clojure-emacs/enrich-classpath. Its dep tree is so small that non-parallel performance still feels fairly snappy.

vemv commented 2 years ago

Thanks! A release would be appreciated.

vemv commented 2 years ago

Any luck with a release? 🙏