Fix intermitent broken files when inlining

lread commented 2 years ago

We had a wee bug which caused duplicate processing of the same source file for a single ns rename. Since we are, by default, processing files in parallel, this can lead to corrupt results.

This change:

addresses the wee bug that caused duplicate processing: mranderson.util.remove-subdirs now also removes duplicate dirs.
throws an internal error when duplicate files are detected prior to embarking on the ns rename processing

And also:

any file-seq I noticed, I converted to non-lazy. These lazy file-seqs had me a bit confused during debugging, due to the way I was debugging, they were being resolved after files had changed on the filesystem.

Extra Testing

I did some extra testing using cider-nrepl v0.28.6 on macOS using Temurin 17.0.4.1 JDK. I ran 100 inline-dep generation runs against:

current: 0.5.4-SNAPSHOT
new: same but with this change

I compared target/srcdeps.

current:

13 of the 100 runs produced corrupt source files
avg time to processs: 62.2s

new:

0 of 100 runs produced corrupt source files
avg time to process: 53.8s

Closes #56

benedekfazekas commented 2 years ago

this is a very wlc PR 👏 . will have a proper look shortly

lread commented 2 years ago

@vemv thanks for taking time to review, much appreciated!

lread commented 2 years ago

Ok @benedekfazekas, I've address @vemv's feedback, lemme know if you'd like any further changes.

benedekfazekas commented 2 years ago

thank you @lread much appreciated!

lread commented 2 years ago

My pleasure @benedekfazekas, glad to be of help!

benedekfazekas / mranderson

Fix intermitent broken files when inlining #74