search

benedekfazekas / mranderson

Dependency inlining and shadowing
Eclipse Public License 1.0
151 stars 14 forks source link

dev/ci: happy with codecov.io behaviour? #84

Closed lread closed 2 years ago

lread commented 2 years ago

@benedekfazekas I too use codecov.io for rewrite-clj.

Are you happy with the current behaviour? If so, please close this issue.

If not, for your consideration, my preferences for rewrite-clj are:

  1. I'm interested in code coverage not as some goal of lines covered by tests, but as passive information.
  2. I have no interest in failing any build on any code coverage metric
  3. I have no interest in code coverage reports in PR comments

I'm happy to bring all, none or part of my rewrite-clj codecov.io config over to MrAnderson. Lemme know.

benedekfazekas commented 2 years ago

sounds good to me. agree on not failing builds on coverage. pls go ahead