search

benedekh / WeLoveClouds

Repository for submissions on the CloudDB course.
0 stars 1 forks source link

Dev/ecs first pass #88

Closed ghost closed 7 years ago

ghost commented 7 years ago

ECS-first-pass just contains command stubs and a command factory.

banctilrobitaille commented 7 years ago

Not clean enough to ship, be careful with the naming convention :+1:

benedekh commented 7 years ago

Another point: It is a bad idea to have two classes with names that contain the same characters, because Windows disregards the difference between lowercase and uppercase letters in filename. E.g. weloveclouds.ecs.client.ECSclient vs. weloveclouds.ecs.client.EcsClient which one to keep?

benedekh commented 7 years ago

@banctilrobitaille another point: On the feature/messages branch a class is already introduced which encapsulates a ServerConnectionInfo and a HashRange -> weloveclouds.hashing.models.RingMetadataPart. Maybe we could use that in weloveclouds.ecs.models.metadata.StorageNode.

Also weloveclouds.hashing.models.RingMetadata is similar to weloveclouds.ecs.models.metadata.Metadata.

ghost commented 7 years ago

Sorry guys I've managed to break this branch and I can't figure out how to fix it. I'll close the pull request, make a new branch from feature/ecs-project, copy my changes then make a new request.