benedekrozemberczki / graph2vec

A parallel implementation of "graph2vec: Learning Distributed Representations of Graphs" (MLGWorkshop 2017).
https://karateclub.readthedocs.io/
GNU General Public License v3.0
901 stars 169 forks source link

json file reading #22

Closed DinoBenevento closed 4 years ago

DinoBenevento commented 4 years ago

Dear benedekrozemberczki, I’m a student in Computer Science, from the University of Salerno. I’m dealing with your graph2vec implementation after reading the related article, which I found very interesting. When trying to run your code, I find a little bug. Here below you can find the error and my fix. parser.add_argument("--input-path", nargs="?", default="../dataset", help="Input folder with jsons.")

parser.add_argument("--output-path", nargs="?", default="../features/nci2.csv", help="Embeddings path.") at line 111 of the script graph2vec, the variable global was empty, so without the json files of the dataset folder. graphs = glob.glob(args.input_path + "*.json")

I rewrite the code in this way to extract the files into the directory:

graphs = [] pathfilename = args.input_path for files in os.listdir(pathfilename): graphs.append(pathfilename + '/' + files)

Hope this will help you :D Given Graph2vec will be a main part of my thesis, don’t you mind if I contact you in case of difficulties?

Kind regards, Gerardo "Dino" Benevento

benedekrozemberczki commented 4 years ago

Hi there Dino,

Are you a windows user?

This package includes a range of Graph2Vec like methods:

https://github.com/benedekrozemberczki/karateclub

Bests,

Benedek

On Mon, 3 Feb 2020 at 20:50, DinoBenevento notifications@github.com wrote:

Dear benedekrozemberczki, I’m a student in Computer Science, from the University of Salerno. I’m dealing with your graph2vec implementation after reading the related article, which I found very interesting. When trying to run your code, I find a little bug. Here below you can find the error and my fix. parser.add_argument("--input-path", nargs="?", default="../dataset", help="Input folder with jsons.")

parser.add_argument("--output-path", nargs="?", default="../features/nci2.csv", help="Embeddings path.") at line 111 of the script graph2vec, the variable global was empty, so without the json files of the dataset folder. graphs = glob.glob(args.input_path + "*.json")

I rewrite the code in this way to extract the files into the directory:

graphs = [] pathfilename = args.input_path for files in os.listdir(pathfilename): graphs.append(pathfilename + '/' + files)

Hope this will help you :D Given Graph2vec will be a main part of my thesis, don’t you mind if I contact you in case of difficulties?

Kind regards, Gerardo "Dino" Benevento

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/benedekrozemberczki/graph2vec/issues/22?email_source=notifications&email_token=AEETMFZ76ZIPK5WFDEHUD33RBB7RHA5CNFSM4KPL2WW2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IKWUNOQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEETMF2GFF66QFQDUFQXYR3RBB7RHANCNFSM4KPL2WWQ .

benedekrozemberczki commented 4 years ago

Would you reply?

benedekrozemberczki commented 4 years ago

Okay. Let us close this for now.