benedekrozemberczki / karateclub

Karate Club: An API Oriented Open-source Python Framework for Unsupervised Learning on Graphs (CIKM 2020)
https://karateclub.readthedocs.io
GNU General Public License v3.0
2.17k stars 247 forks source link

Replaced fullargsspec with signature, as it broke in my system #111

Closed LucaCappelletti94 closed 2 years ago

LucaCappelletti94 commented 2 years ago

Hello, I did a 🍌.

While generally fullargsspec works better than signature, since the latter can break when dealing with things such as code bindings, I discovered the hard way that the former breaks in some cases, like our friend NMF, and return an empty list of args and kwargs.

I have no clue why it does break.

Notwithstanding, I replaced it with signature, which seems more stable in these use cases.