search

benedekrozemberczki / karateclub

Karate Club: An API Oriented Open-source Python Framework for Unsupervised Learning on Graphs (CIKM 2020)
https://karateclub.readthedocs.io
GNU General Public License v3.0
2.16k stars 246 forks source link

A question for BANE, TENE and TADW #36

Closed Barron429 closed 4 years ago

Barron429 commented 4 years ago

Hi,

I am trying to use there 3 methods, but my graph is not connected:

site-packages/karateclub/estimator.py", line 50, in _check_connectivity raise ValueError("Graph is not connected. Please see requirements.")

Could I know if it is necessary to make graph connected? and how to avoid this problem?

Thanks

benedekrozemberczki commented 4 years ago

You can remove the connectedness check. We created a pretty specific interface for checking the requirements, in later versions I might remove that requirement.

On Wed, 22 Jul 2020 at 17:59, Barron429 notifications@github.com wrote:

Hi,

I am trying to use there 3 methods, but my graph is not connected:

site-packages/karateclub/estimator.py", line 50, in _check_connectivity raise ValueError("Graph is not connected. Please see requirements.")

Could I know if it is necessary to make graph connected? and how to avoid this problem?

Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/benedekrozemberczki/karateclub/issues/36, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEETMF73FEYMU2W35NV6L5LR44LGZANCNFSM4PE46JCQ .

Barron429 commented 4 years ago

Thanks for your reply. Could I know if removing the connectedness check will not hurt the performance of these 3 methods?

benedekrozemberczki commented 4 years ago

BANE should not be hurt as it is an inductive method and context is defined by features. TADW and TENE are transductive - removing the condition is risky.