search

benedekrozemberczki / pytorch_geometric_temporal

PyTorch Geometric Temporal: Spatiotemporal Signal Processing with Neural Machine Learning Models (CIKM 2021)
MIT License
2.61k stars 367 forks source link

change on _set_hidden_state() #187

Closed h3dema closed 2 years ago

h3dema commented 2 years ago

Allows TGCN2 to work with batch from different sizes. Current implementation forces all batches to be the same size (defined by self.batch_size).

codecov-commenter commented 2 years ago

Codecov Report

Merging #187 (cbb8ba5) into master (f76e06f) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #187   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          57       57           
  Lines        4989     4989           
=======================================
  Hits         4955     4955           
  Misses         34       34
Impacted Files Coverage Δ
...rch_geometric_temporal/nn/recurrent/temporalgcn.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jamesmyatt commented 2 years ago

Documentation for A3TGCN2 also needs updating to indicate that batch_size is unused.