search

benedekrozemberczki / pytorch_geometric_temporal

PyTorch Geometric Temporal: Spatiotemporal Signal Processing with Neural Machine Learning Models (CIKM 2021)
MIT License
2.61k stars 367 forks source link

Remove dependency on six #189

Closed jamesmyatt closed 1 year ago

jamesmyatt commented 2 years ago

Six is not required since only Python 3 is supported Also remove unused "import io"

jamesmyatt commented 2 years ago

Coverage has only dropped because an irrelevant line has been removed: https://github.com/benedekrozemberczki/pytorch_geometric_temporal/pull/189/files#diff-a95a5b7626de5fa140608d7d7f5cfda1064e4179c5b2c8b7d39138fc72e6f20dL1

codecov-commenter commented 2 years ago

Codecov Report

Merging #189 (0972add) into master (46abd39) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   99.31%   99.31%   -0.01%     
==========================================
  Files          57       57              
  Lines        4989     4980       -9     
==========================================
- Hits         4955     4946       -9     
  Misses         34       34
Impacted Files Coverage Δ
torch_geometric_temporal/dataset/chickenpox.py 100.00% <100.00%> (ø)
torch_geometric_temporal/dataset/encovid.py 100.00% <100.00%> (ø)
torch_geometric_temporal/dataset/metr_la.py 100.00% <100.00%> (ø)
torch_geometric_temporal/dataset/montevideo_bus.py 100.00% <100.00%> (ø)
torch_geometric_temporal/dataset/mtm.py 100.00% <100.00%> (ø)
torch_geometric_temporal/dataset/pedalme.py 100.00% <100.00%> (ø)
torch_geometric_temporal/dataset/pems_bay.py 100.00% <100.00%> (ø)
torch_geometric_temporal/dataset/twitter_tennis.py 97.61% <100.00%> (-0.03%) :arrow_down:
torch_geometric_temporal/dataset/wikimath.py 100.00% <100.00%> (ø)
torch_geometric_temporal/dataset/windmilllarge.py 100.00% <100.00%> (ø)
... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

benedekrozemberczki commented 2 years ago

Hi there @jamesmyatt, there are conflicts.

jamesmyatt commented 1 year ago

@benedekrozemberczki . Conflict has been resolved.

CI check failure is due to an irrelevant coverage change: https://github.com/benedekrozemberczki/pytorch_geometric_temporal/pull/189#issuecomment-1231828583