search

benedictkhoomw / pe

0 stars 0 forks source link

DG: Review Mode Sequence Diagram activation bar extends past final return arrow #10

Open benedictkhoomw opened 3 years ago

benedictkhoomw commented 3 years ago

Where it is

DG -> [Implemented] Review feature -> the only sequence diagram in this sub-section

Issue and justification

The activation bar for MainWindow extends past the final return arrow. This is incorrect formatting as the bar should end with the final return arrow, and this could be misleading to readers.

Medium severity was given because even though it is incorrect syntax, readers familiar with sequence diagrams will likely recognize it as simply a mistake but still understand that the activation bar should end at the last return arrow.

Evidence

image.png

nus-pe-bot commented 3 years ago

Team's Response

This bug only appears in very rare situation and it only causes minor inconvenience for users who read the Developer Guide, and as you mentioned, users are likely to recognize that it is simply a minor mistake.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]