search

benedictkhoomw / pe

0 stars 0 forks source link

Undo success message typo #4

Open benedictkhoomw opened 3 years ago

benedictkhoomw commented 3 years ago

How to reproduce

  1. Launch app
  2. Execute the following command(s)
  3. add q/my question a/e=mc^2 c/Physics p/High
  4. undo

Expected result

Something like "The operation has been undone."

Actual result

A grammatically incorrect message which has debatable meaning: if taken literally, it could mean "FlashBack (the app) has been undone" but it should be referring to just the previous command.

image.png

Justification for severity

Very Low was chosen because it is cosmetic and most people should be able to guess from context what it means. But it was still an unexpected message.

nus-pe-bot commented 3 years ago

Team's Response

No response provided.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Grammatical error in displayed message for undo and redo command

image.png image.png

Should be something like "The previous command has been undone" as the thing that has been undone is the command, not the app

[original: nus-cs2103-AY2021S2/pe-interim#2869] [original labels: severity.VeryLow type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No response provided.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]