search

benedictrobb / beevr

https://beevr.herokuapp.com
8 stars 1 forks source link

New categories menu #112

Closed antoniotrkdz closed 7 years ago

antoniotrkdz commented 7 years ago

Solved category selection issue on form register students

des-des commented 7 years ago

@antoniotrkdz Duplicate commits on other pulls I have already looked at

des-des commented 7 years ago

@antoniotrkdz STOP

antoniotrkdz commented 7 years ago

Hi Eoin, I have merged master in and I hope the size of the PR shrinked. Besides merging master in I made a small change to categories file to correct a mistake, but hopefully this PR should be of an acceptable size. I am holding to others to be pushed to avoid the the issues we are having now. Please do not review thw other PR still on list until you merged this.

Sorry again for the inconvenience, I was just tryitng to speed up the thing, but I have ended up slowing it down instead....

antoniotrkdz commented 7 years ago

Hi Eoin, I have included the react-widget.css in the main style.css, to avoid complicated configurations. I also mdified the /build directory route to NOT require authentication as Maja was't able to access it on heroku after the new auth was merged into master.

des-des commented 7 years ago

I also mdified the /build directory route

@antoniotrkdz why did you do that on this pull

I have explicitly asked you not to add extra changes to pulls that I have reviewed. I have said this countless times.