search

benedictrobb / beevr

https://beevr.herokuapp.com
8 stars 1 forks source link

selection menu added to post-job form #114

Closed antoniotrkdz closed 7 years ago

antoniotrkdz commented 7 years ago

Rebranched from master

antoniotrkdz commented 7 years ago

Hi,

I have reworked this entirely based on today's progress. Sorry for the double work but I tried to address your comments.

Please merge new-categories-menu first! And before that merge session management!

Thanks

antoniotrkdz commented 7 years ago

I have reworked it beacause it was broken, I beleved it was working and I requested you to merge the PR. If I delete the commits and you merge the first version it will break master. And in the new version I have integrated the changes requested.

des-des commented 7 years ago

@antoniotrkdz okay, I will review the whole pull request again

des-des commented 7 years ago

@antoniotrkdz

I just looked at some of these commits on another pull.

image

I am trying to be patient here

image

I am not sure you understand. Do not ask me to review the same commits twice.

  1. Wait for other pull to go in
  2. merge master into this branch
  3. assign me

please please @antoniotrkdz I am sad