benedmunds / CodeIgniter-Ion-Auth

Simple and Lightweight Auth System for CodeIgniter
http://benedmunds.com/ion_auth/
MIT License
2.35k stars 1.14k forks source link

Update Auth.php #1566

Open dgvirtual opened 2 years ago

dgvirtual commented 2 years ago

Remove trim function from the validation rules as "CI4 validation never changes your data".

benedmunds commented 2 years ago

We should still trim these in the app code right?

dgvirtual commented 2 years ago

I guess so, but trimming should be done before validation. If we validate untrimmed identity, for example, and the user happens to leave a space at the end, the identity will validate despite such identity already existing, right?

benedmunds commented 2 years ago

Yep agreed

setioaji commented 1 year ago

need trim