search

benefitcloud / ember-uploader

An Ember library for uploading files
MIT License
345 stars 97 forks source link

update to 3.0 #171

Closed snewcomer closed 6 years ago

snewcomer commented 6 years ago

Ready for merge after approval!

close #167 close #160

Dhaulagiri commented 6 years ago

I re-enabled tests for PRs in travis so the next push to this PR should hopefully trigger a CI run 🤞

@snewcomer let me know when this is no longer WIP and we can get it :shipit:

snewcomer commented 6 years ago

@Dhaulagiri 👋 Got the tests passing and tested this branch out locally and all seems good (although I don't use the full API of this addon). In addition to upgrading, I ran the qunit codemod and the modules codemod.

Would love to get some feedback when you get a chance!

Dhaulagiri commented 6 years ago

Also, if we don't do it here we should make a PR to update the readme to reflect the removal of bower and the addition of yarn

snewcomer commented 6 years ago

@Dhaulagiri Really appreciate the thorough review. Fixed based on your feedback! Do you have write access? Seems I don't.

Dhaulagiri commented 6 years ago

I do. I'm not sure that I have npm publish access though but in either case I'll cut a new release in #173

Dhaulagiri commented 6 years ago

Nope, I don't have access but nevertheless the tagged version could be used via github for now

digitaltoad commented 6 years ago

What is your NPM user so I can give you publish rights?

snewcomer commented 6 years ago

snewcomer 🙏

Dhaulagiri commented 6 years ago

dhaulagiri

digitaltoad commented 6 years ago

Alright I added you both. Thank you again. If you want or need to change the location of the repo, just let me know.

Dhaulagiri commented 6 years ago

published in 1.3.0