search

beneggett / sportradar-api

19 stars 13 forks source link

Fixing Roster #10

Closed Timbinous closed 7 years ago

Timbinous commented 7 years ago

I found out that the roster is getting it's information in a different way when calling game_roster as opposed to game_statistics on lib/sportradar/api/nfl.rb

Also refactored the players to be the returning method as well as return an array as the default in case there are no players returned. Returning nil was causing an issue and since the method name is plural I figured returning an array would be implicit.

phoffer commented 7 years ago

@Timbinous would you mind checking the depth-charts branch to see if that works for your use case? I have changes there for the game roster, which sound like what you're after here.

Timbinous commented 7 years ago

@phoffer It does fix the issue I was having. Thanks for looking at this PR. I will check your other branches next time to make sure it isn't fixed already.