search

beneggett / sportradar-api

19 stars 13 forks source link

fix .env.sample and remove api keys #18

Closed trevorrjohn closed 7 years ago

trevorrjohn commented 7 years ago

The sample file for .env was invalid so I fixed that and I also removed some lingering api keys that were in the codebase that I noticed. You might want to change those keys...

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-8.5%) to 76.464% when pulling 671441c22ba97a982971847e8a1d63b4e287e86d on trevorrjohn:fix-sample-data into b3cef5cd1e4e9e791b0460f7d4381f13e576c300 on beneggett:master.

phoffer commented 7 years ago

Thank you John. The yaml syntax for dotenv is older but still valid. We are using this syntax for convenience for keeping in sync with app config for the internal project we developed the gem for.

We appreciate you alerting us regarding the stray API keys. Those have been corrected in the cassettes and are being handled internally.

Because we prefer the yaml syntax, and additional cassettes required attention, I have fixed those and am closing this PR.

~Lastly, we would be interested in discussing your use case for Sportradar data and potentially collaborating, if you would be amenable to that. We are rapidly developing other sports and improving the gem's interface as we go.~ I just saw your open issue, I'll move conversation over there.