search

benelot / pybullet-gym

Open-source implementations of OpenAI Gym MuJoCo environments for use with the OpenAI Gym Reinforcement Learning Research Platform.
https://pybullet.org/
Other
814 stars 124 forks source link

updating import to reflect new location of bullet_client.py from bullet3 #35

Closed OttPeterR closed 4 years ago

OttPeterR commented 4 years ago

Devs at bullet3 have moved bullet_client from pybullet_envs.bullet to pybullet_utils

old location: (not present) https://github.com/bulletphysics/bullet3/tree/master/examples/pybullet/gym/pybullet_envs/bullet

new location: https://github.com/bulletphysics/bullet3/blob/master/examples/pybullet/gym/pybullet_utils/bullet_client.py

This fixes the error thrown by line 4 of env_bases.py https://github.com/benelot/pybullet-gym/blob/master/pybulletgym/envs/roboschool/envs/env_bases.py

benelot commented 4 years ago

Sounds good! Merging!

lazarox commented 4 years ago

Shouldn't the Mujoco environments be updated in the same fashion? I.e., changing line 4 of

pybullet-gym/pybulletgym/envs/mujoco/envs/env_bases.py

in a similar fashion? Otherwise, those can't loaded either.

benelot commented 4 years ago

I think so. I just do not have much time to maintain the envs recently. If you can send me a PR for it, I will quickly review and accept it. Thanks!

On Tue, Apr 7, 2020 at 10:01 AM Miguel notifications@github.com wrote:

Shouldn't the Mujoco environments be updated in the same fashion? I.e., changing line 4 of

pybullet-gym/pybulletgym/envs/mujoco/envs/env_bases.py

in a similar fashion? Otherwise, those can't loaded either.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/benelot/pybullet-gym/pull/35#issuecomment-610239054, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXXXK75UTB3BQVH3BV63HLRLLMXBANCNFSM4J24ZVHQ .