search

benetech / Imageshare-Extensions

MIT License
0 stars 0 forks source link

When performing a search no feedback given #28

Closed clapierre closed 3 years ago

clapierre commented 3 years ago

Chrome: Canary mv3 (Mac)

When either I select text and do a right click search (standard or advance), or clicking on the button Standard / Advance search from the icon plugin (top right corner of the screen)

There is no indication that anything is happening while the search is being performed.

Can/should we pop up some "Search in progress..." change to a working cursor or something? @sinabahram suggestions? Right now if it takes a while it doesn't look like anything is happening.

LE0616 commented 3 years ago

@clapierre @sinabahram Since this is generally a very short period of time, I really like the idea of a working cursor with maybe a corresponding screen reader announcement.

clapierre commented 3 years ago

That works for me.

sinabahram commented 3 years ago

Working cursor works for now. @LE0616 can you please close this issue once that's pushed?

LE0616 commented 3 years ago

On it. Will do @sinabahram .

jkva commented 3 years ago

This has been part of the extension for a while now -- in addition a hidden screen reader announcement is read out when the search starts.