Open alexrcabral opened 4 years ago
Tested When I'm a log in as user on the Mathshare dashboard, and I click into a set, I am able to view the prompts at the tops of each of the problem cards in my set. @alexrcabral @johnhbenetech I think that when the prompts are long they should be shortened as titles on homepage , we can use " ..." what do you think?
Verified on:
@abaranowska1 it's currently matching the scoped functionality . "If the prompt is longer than a single line, the words should overflow to multiple lines, increasing the size of the problem card further, maintaining the same spacing between the prompt and the equation (as well as the spacing between the equation and the bottom of the card). "
So I would say this issue can move along. If @alexrcabral wants to change this he can create a separate issue later on
@johnhbenetech is correct: truncation of the problem prompt could cause accessibility issues, so in the meantime the overflow is the scoped functionality, which matches what was developed.
On a separate note, there is an issue with the margins / alignment which doesn't match the scope and design above.
Pushed a fix for this
@alexrcabral @rupeshparab For me it looks fine.
This task defines the surfacing of the prompt for individual problem cards.
Full Mockup
The above mockup shows the issue in context of the individual set view.
Notable changes from mockups:
Prompt
Each problem card should contain the prompt for the given problem, e.g. "Solve for x". This should be in the font, size, spacing, and styling given in Invision. If the prompt is longer than a single line, the words should overflow to multiple lines, increasing the size of the problem card further, maintaining the same spacing between the prompt and the equation (as well as the spacing between the equation and the bottom of the card).
Reference
Style Guides: https://invis.io/CQYLLW8J49U Mobile Mockups: https://invis.io/5HYLLW1G4BD Fonts: https://www.dropbox.com/sh/c12m6ufweyds20d/AAAdXNPOt8e52DkSAr9pd-a-a/Fonts?dl=0
Acceptance criteria:
Given that I'm a user on the Mathshare dashboard, when I click into a set, I should be able to view the prompts at the tops of each of the problem cards in my set.