benetech / MathShare

MIT License
9 stars 3 forks source link

Problem Card: Prompt (Mobile > Dashboard)  #1415

Open alexrcabral opened 4 years ago

alexrcabral commented 4 years ago

This task defines the surfacing of the prompt for individual problem cards. 

Full Mockup

Mockup of individual set view. The universal nav bar is on the top, followed by a back arrow, the problem set title Distance Rate & Time, and a three dot dropdown by the set title. Beneath are two problem cards, rounded rectangles with pastel backgrounds. Each card has the number in a small box in the top left, the prompt and equation in the middle of the card, and a three dot dropdown in the top right of the card. The second card has a black checkmark in a green circle also in the top right.

The above mockup shows the issue in context of the individual set view.

Notable changes from mockups: 

Prompt 

Each problem card should contain the prompt for the given problem, e.g. "Solve for x". This should be in the font, size, spacing, and styling given in Invision. If the prompt is longer than a single line, the words should overflow to multiple lines, increasing the size of the problem card further, maintaining the same spacing between the prompt and the equation (as well as the spacing between the equation and the bottom of the card). 

Reference

Style Guides: https://invis.io/CQYLLW8J49U Mobile Mockups: https://invis.io/5HYLLW1G4BD Fonts: https://www.dropbox.com/sh/c12m6ufweyds20d/AAAdXNPOt8e52DkSAr9pd-a-a/Fonts?dl=0

Acceptance criteria: 

Given that I'm a user on the Mathshare dashboard, when I click into a set, I should be able to view the prompts at the tops of each of the problem cards in my set. 

abaranowska1 commented 4 years ago

Tested When I'm a log in as user on the Mathshare dashboard, and I click into a set, I am able to view the prompts at the tops of each of the problem cards in my set. @alexrcabral @johnhbenetech I think that when the prompts are long they should be shortened as titles on homepage , we can use " ..." what do you think?

image image

Verified on:

johnhbenetech commented 4 years ago

@abaranowska1 it's currently matching the scoped functionality . "If the prompt is longer than a single line, the words should overflow to multiple lines, increasing the size of the problem card further, maintaining the same spacing between the prompt and the equation (as well as the spacing between the equation and the bottom of the card). "

So I would say this issue can move along. If @alexrcabral wants to change this he can create a separate issue later on

alexrcabral commented 4 years ago

@johnhbenetech is correct: truncation of the problem prompt could cause accessibility issues, so in the meantime the overflow is the scoped functionality, which matches what was developed.

On a separate note, there is an issue with the margins / alignment which doesn't match the scope and design above.

  1. Both the prompt and equation should be next to the number as shown in the design, not underneath.
  2. The prompt should also stretch further than is currently shown (as far as the far side of the checkmark, and the near side of where the three dot menu would be.
QA screenshot showing left justified prompts and equations, cutting off just over halfway across the problem card. Mockup of individual set view. The universal nav bar is on the top, followed by a back arrow, the problem set title Distance Rate & Time, and a three dot dropdown by the set title. Beneath are two problem cards, rounded rectangles with pastel backgrounds. Each card has the number in a small box in the top left, the prompt and equation in the middle of the card, and a three dot dropdown in the top right of the card. The second card has a black checkmark in a green circle also in the top right.
rupeshparab commented 4 years ago

Pushed a fix for this

abaranowska1 commented 4 years ago

@alexrcabral @rupeshparab For me it looks fine. image image