benetech / MathShare

MIT License
9 stars 3 forks source link

Set Creation: New Problem Set Button (Small Screens, e.g. Single Column)  #1594

Open alexrcabral opened 3 years ago

alexrcabral commented 3 years ago

Set Creation: New Problem Set Button (Small Screens, e.g. Single Column) 

Mockup of mobile view. Underneath the universal nav bar is the heading My Created Sets. Directly underneath is a rounded rectangle button with a plus icon in a circle, with the title New Problem Set. Beneath are the user's sets.

New Problem Set Button

The "New Problem Set" should be the first item in the new "My Created Sets" section. 

When pressed, the "New Problem Set" should create a new empty /edit set, using the existing naming convention (e.g. "New Problem Set 12-21-2020"), and take the user to the editing view of the newly created set. 

Appearance: as shown above, a rounded rectangle with an icon (white plus sign within a purple circle) next to the words "New Problem Set". When the problem set cards are in a single column (e.g. for smaller width screens), the New Problem Set button should match the length of the problem set cards

Alt Text: "Add New Problem Set" 

Acceptance criteria: 

Given that I'm a logged-in user (student/teacher/other) on the v2 view, when I go to the "My Created Sections", I should encounter a button to add a New Problem Set. If I click this button, I should be brought to the edit page of a new empty problem set. 

abaranowska1 commented 3 years ago

Tested with success

Selection_878 Selection_879 Selection_880 Selection_881

alexrcabral commented 3 years ago

the New Problem Set button should match the length of the problem set cards

@rupeshparab I'm getting some weird behavior on this. when the problem set cards are exceptionally long, the new problem set button remains short.

Screen Shot showing long problem set cards, with the button being about one fifth the size

And then when the problem set cards are short, the new problem set button sometimes corrects to be longer than the cards themselves.

Screen Shot showing short problem set cards, with the new problem set button sticking out an inch or so on either end.
rupeshparab commented 3 years ago

@alexrcabral Do we always want the width of the New Problem Set button to be same as the card?

I have kept a breakpoint of 480px, when the screen size is less than that the button size would match for larger mobile screens, the button size would be fit for the inner content

alexrcabral commented 3 years ago

Addressed on touch-point call:

abaranowska1 commented 3 years ago

In my opinion, now it looks fine. Selection_957 Selection_956

alexrcabral commented 3 years ago

Thanks @rupeshparab, this is looking much better