search

benetech / MathShare

MIT License
9 stars 3 forks source link

Shortcut suggesting feature. #421

Closed kkrawczyk123 closed 6 years ago

kkrawczyk123 commented 6 years ago

I have noticed that when input shortcuts into my work area some suggesting/helping window is showing up randomly. Screenshots attached: screenshot from 2018-08-31 09-44-26 screenshot from 2018-08-31 09-44-01 screenshot from 2018-08-31 09-43-45

I think that suggesting idea is a good one but it will require handling it. @johnhbenetech what are your thoughts?

johnhbenetech commented 6 years ago

Yes, we should try to match MathLive as much as possible. so i think we should try to display these correctly

afijal commented 6 years ago

It's more like command suggesting popover than shortcut, but anyway, seems like it was a MathLive issue, I've fixed this in our project and created a pr to MathLive repo https://github.com/arnog/mathlive/pull/107.

Behavior isn't ideal when the popup shows and we scroll the page, but this is how it works in the library

kkrawczyk123 commented 6 years ago

Good job @afijal ! Commands are suggested, user is able to change them using up and down arrows and popover is displayed right below input text, not randomly like before. I agree that it is not perfect when scrolling the page but it is not a very common use case either.